Fix é characters that were broken by Uncrustify #28208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses broken accented characters in French translations resulting from Uncrustify reformatting.
- Corrects accented characters for playing technique annotations.
- Updates the translation string for the "Barré line" in the guitar palette.
Comments suppressed due to low confidence (2)
src/palette/internal/palettecreator.cpp:1607
- The accented characters in the translation string have been corrected. Please verify that this change is consistent with other translation strings in the codebase.
{ QT_TRANSLATE_NOOP("palette", "détaché"), PlayingTechniqueType::Detache },
src/palette/internal/palettecreator.cpp:1766
- The update to the accented string 'Barré line' ensures the proper French accent. Confirm this correction aligns with the intended display for users.
sp->appendElement(capoLine, QT_TRANSLATE_NOOP("palette", "Barré line"), 0.8);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened in #28118